Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cannot build pyopengl-accelerate with clang 15 #107

Open
davidjmeyer opened this issue Nov 17, 2023 · 4 comments
Open

cannot build pyopengl-accelerate with clang 15 #107

davidjmeyer opened this issue Nov 17, 2023 · 4 comments

Comments

@davidjmeyer
Copy link

Clang 15 has upgraded -Wint-conversion from a warning to a default error, and this means we cannot build pyopengl-accelerate

I get the following error:

 src/numpy_formathandler.c:9802:3: error: incompatible pointer to integer conversion returning 'void *' from a function with result type 'int' [-Wint-conversion]

See release notes: https://releases.llvm.org/15.0.0/tools/clang/docs/ReleaseNotes.html

The -Wint-conversion warning diagnostic for implicit int <-> pointer conversions now defaults to an error in all C language modes. It may be downgraded to a warning with -Wno-error=int-conversion, or disabled entirely with -Wno-int-conversion.

@0xorial
Copy link

0xorial commented May 3, 2024

Seems pretty major. Can anyone merge the PR, or find a workaround?

@adamsmatthew
Copy link

adamsmatthew commented Sep 17, 2024

I was able to work around this by using the downgrade mentioned in the top comment via CFLAGS. Specifically, I ran

export CFLAGS="-Wno-error=int-conversion"

before running

python3 -m pip install -r requirements.txt

Since I was also running into #118, my requirements.txt contained the following:

PyOpenGL @ git+https://github.com/mcfletch/[email protected]#egg=PyOpenGL
PyOpenGL_accelerate @ git+https://github.com/mcfletch/[email protected]#egg=PyOpenGL_accelerate&subdirectory=accelerate

(copied from a comment on that issue).

I also tried to get -Wno-error=int-conversion to work through requirements.txt via --config-settings - i.e., without using CFLAGS, but I was unsuccessful.

@ROCKLOTUS
Copy link

I was able to work around this by using the downgrade mentioned in the top comment via CFLAGS. Specifically, I ran

export CFLAGS="-Wno-error=int-conversion"

before running

python3 -m pip install -r requirements.txt

Since I was also running into #118, my requirements.txt contained the following:

PyOpenGL @ git+https://github.com/mcfletch/[email protected]#egg=PyOpenGL
PyOpenGL_accelerate @ git+https://github.com/mcfletch/[email protected]#egg=PyOpenGL_accelerate&subdirectory=accelerate

(copied from a comment on that issue).

I also tried to get -Wno-error=int-conversion to work through requirements.txt via --config-settings - i.e., without using CFLAGS, but I was unsuccessful.

Successfully installed, Thanks

@jimmyken
Copy link

I was able to work around this by using the downgrade mentioned in the top comment via CFLAGS. Specifically, I ran

export CFLAGS="-Wno-error=int-conversion"

before running

python3 -m pip install -r requirements.txt

Since I was also running into #118, my requirements.txt contained the following:

PyOpenGL @ git+https://github.com/mcfletch/[email protected]#egg=PyOpenGL
PyOpenGL_accelerate @ git+https://github.com/mcfletch/[email protected]#egg=PyOpenGL_accelerate&subdirectory=accelerate

(copied from a comment on that issue).
I also tried to get -Wno-error=int-conversion to work through requirements.txt via --config-settings - i.e., without using CFLAGS, but I was unsuccessful.

Successfully installed, Thanks

Yes! It is work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants