Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'output' arg in many functions #52

Open
williambl opened this issue Jul 14, 2019 · 2 comments
Open

'output' arg in many functions #52

williambl opened this issue Jul 14, 2019 · 2 comments

Comments

@williambl
Copy link
Member

Many functions have an 'output' argument which, if true, prints the output as well as returning it. I feel like this just clutters the code a bit, and doesn't really fit with the idea that a function should do one thing only.

This issue is for discussion of whether or not they should be removed, and is the first in a few issues I'm going to make regarding the problem of 'code smell'.

@Valiec
Copy link
Contributor

Valiec commented Jul 14, 2019

I'm going to investigate which functions are doing this and how important it really is (i.e. how much it is making other code cleaner).

@Valiec
Copy link
Contributor

Valiec commented Jul 14, 2019

They aren't that important, I'm splitting off the print output thing as its own function (and I only found 4 functions that do this in delta_util.py, will look in other files after I fix these).

williambl added a commit that referenced this issue Jul 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants