Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep scenes when added to show and propagate change to all sequences based on a scene #1162

Open
bgnt44 opened this issue Nov 21, 2018 · 6 comments

Comments

@bgnt44
Copy link

bgnt44 commented Nov 21, 2018

I've worked a bit on the 4.12 to add thoses 2 features

  1. on/off button in show editor to be able to auto-copy scene when added and so keeping the original scene in the scene list
  2. push button that propagate the sequence step 1 values to all other sequences in the same track using the same source scene

are those 2 functions interesting for the community and if so how to submit a code review

@bgnt44 bgnt44 changed the title Keep scenes when added to show and propagate change to all sequences based on a change Keep scenes when added to show and propagate change to all sequences based on a scene Nov 21, 2018
@bgnt44
Copy link
Author

bgnt44 commented Nov 21, 2018

Just a side note, new here and really appreciate that software and how its coded, basically new to Qt dev too so you ll have to forgive my code quality if you decide to merge thoses changes

@mcallegari
Copy link
Owner

mcallegari commented Nov 21, 2018

Can you please elaborate the need of this change and perhaps share screenshots or a video of how it looks like ?
Also a reference to the commits in your repository would be helpful to understand the details of this change.
As for "code review", in GitHub it's simply called "Pull request". There is a button in your fork to create it. I will be notified when that happens.
Personal opinion: I'm a bit reluctant to make changes to the Show manager. It's already pretty messy and I'm afraid adding more options will end up being confusing rather than helpful.

@bgnt44
Copy link
Author

bgnt44 commented Nov 26, 2018

Sorry didn’t took time to answer, I worked actively on the show manager the last few days trying to understand how it works and how it was supposed to be used.
Although I like it and and I understand the integration between scene , chaser and sequence , i think as you said there is a bit of complexity due to the strong integration between tracks and scenes.

I have worked on a different concept where tracks are not fully linked to scene but instead can be linked optionally to channel groups so you get tracks for Colors , tracks for gobos, track for ... etc and still tracks that can handle chaser and the rest

There are also ui challenges , cause I would like sequences to be easily distinguish in the show manager.

I forked the code and as soon as I have a beta version, I would really appreciate if you could have a look and tell me how you feel about it.

short alpha preview :
image

@mcallegari
Copy link
Owner

I hope you know I am working on QLC+ 5 and I already simplified the Show Manager ?
I already removed the Scene bounding and now Scenes can be added to tracks.
See https://youtu.be/Ko_5oCPmqsM
In other words: are we sure spending efforts on QLC+ 4 is worth it at this point ?

@bgnt44
Copy link
Author

bgnt44 commented Nov 26, 2018

Thats a good point . I choose to extends the QLC 4 cause its stable all around and its much easier to start from a stable base. Second point, im not familiar at all with Qml, the "coded ui" in QLC4 is more familiar.

WHat i could do is finishing at least the changes so you can try it, and if you feel the behaviour is interesting i could help implement in qlc5

@mcallegari
Copy link
Owner

Adding features to QLC+ 4 means users will eventually get used to them and expect to find them in QLC+ 5. Meaning: doing the work twice.

WHat i could do is finishing at least the changes so you can try it, and if you feel the behaviour is interesting i could help implement in qlc5

Can you please make a list of the changes you intend to do ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants