Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

com.mbeddr.mpsutil.actionsfilter migration to MPS 2021.3.3 #2298

Open
KemalSoysal opened this issue Aug 28, 2023 · 0 comments
Open

com.mbeddr.mpsutil.actionsfilter migration to MPS 2021.3.3 #2298

KemalSoysal opened this issue Aug 28, 2023 · 0 comments

Comments

@KemalSoysal
Copy link
Contributor

KemalSoysal commented Aug 28, 2023

com.mbeddr.mpsutil.actionsfilter.ideaplugin looks unused and the class loading issue happened in MPS 2017.2.
From a first look, we should try to:

  • remove*.ideaplugin
  • remove the old idea plugin com.mbeddr.mpsutil.actionsfilter.lang
  • merge the MPS and IntelliJ plugin and check if the class loading issue still persists. The extra XML IntelliJ platform declarations should hopefully also work in the MPS plugin nowadays.
  • while we are at it: handle the missing IntelliJ plugin more gracefully when an action profile should activate than disabling many actions by accident and making MPS unusable.
    Changes to the plugin would also be a lot easier to make if we could just reload the changes models instead of having to reinstall the plugins.
  • Add the missing ActionBase.refersToActionId implementation like in the RemoveAction_Behavior implementation
public virtual boolean refersToActionId(string id) 
   overrides ActionBase.refersToActionId { 
   return id != null && id.equals(this.actionId); 
}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant