Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The logic behind HighDensityRegionAlgorithm.plotContour is weird. #6

Closed
mbaudin47 opened this issue Feb 22, 2019 · 4 comments · Fixed by #17
Closed

The logic behind HighDensityRegionAlgorithm.plotContour is weird. #6

mbaudin47 opened this issue Feb 22, 2019 · 4 comments · Fixed by #17

Comments

@mbaudin47
Copy link
Owner

The logic behind HighDensityRegionAlgorithm.plotContour is weird.

This is the current code:

  • plotContour(plotData=False, plotOutliers=False) : plots contours and outliers
  • plotContour(plotData=False, plotOutliers=True) : plots contours and inliers
  • plotContour(plotData=True, plotOutliers=True) : plots contours, outliers and inliers

The two functionnalities should be separated into three methods:

  • drawContour() : plots only the contour
  • drawInliers() : plots the inliers
  • drawOutliers() : plots the outliers
@tupui
Copy link
Contributor

tupui commented Feb 22, 2019

OK to separate this method into three methods. @mbaudin47 Then what is the desired API for ProcessHighDensityRegionAlgorithm?

@tupui
Copy link
Contributor

tupui commented Feb 22, 2019

I have done a proposition in #9 .

@tupui
Copy link
Contributor

tupui commented Feb 26, 2019

Do pairplot in n-dimension using the 2D distribution using self.distribution.getMarginal([i, j])

@mbaudin47
Copy link
Owner Author

Pour créer un subplot contenant des graphiques OT, voir "Annexe : dessiner plusieurs distributions dans un même graphique" dans :

https://github.com/mbaudin47/otsupgalilee-eleve/blob/master/1-Intro-OT/Distributions.ipynb

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants