Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wrong placement for TH models with different orientation in the same pcb #99

Open
easyw opened this issue Sep 19, 2023 · 0 comments
Open

Comments

@easyw
Copy link

easyw commented Sep 19, 2023

Hi,
when a TH footprint is present in a pcb with a different orientation, the script should adjust the translation considering the footprint orientation in the pcb (getting it from -all-pos.csv file).
For SMD fp the issue is not present because they are placed on fp center, in case of TH fp, the anchor is instead on first pin.
This is generating a misplacement in JLC assembly service
i.e. in case of a PinHeader placed in the pcb with 0deg, 90deg, 180deg and 270deg, the transformation will generate 4 different alignment to the original footprint
"^PinHeader_1x02_P2\.54mm_Vertical",90,1.27,0.0

jlc-tools-test

@easyw easyw changed the title wrong placement forr TH models with different orientation in the same pcb wrong placement for TH models with different orientation in the same pcb Sep 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant