Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[email protected]: hash check failed #277

Closed
fomlhaut opened this issue Jan 29, 2024 · 2 comments · Fixed by #279
Closed

[email protected]: hash check failed #277

fomlhaut opened this issue Jan 29, 2024 · 2 comments · Fixed by #279

Comments

@fomlhaut
Copy link

Scoop output:

ERROR Hash check failed!
App:         nerd-fonts/Victor-Mono
URL:         https://rubjo.github.io/victor-mono/VictorMonoAll.zip
First bytes: 50 4B 03 04 14 00 00 00
Expected:    eab377ad3bcc7a202697c024ebb8c8728f99789c4f093d358f3d202052cc9496
Actual:      16f327aa8f98137e1ff619c231c283e4cdc6a6f50027ca123cb58e8a79a8a095

What I've found is that the hash of the file VictorMonoAll.zip contained inside the ZIP file https://github.com/rubjo/victor-mono/archive/refs/tags/v1.5.6.zip is eab377ad..., but the hash of the file directly downloadable from https://rubjo.github.io/victor-mono/VictorMonoAll.zip is 16f327aa....

Apart from that, both files contain the exact same folders and font files (after extraction, all the files are exactly the same, byte for byte). The only difference seems to be some bytes at the end of the ZIP files (maybe metadata?) which do not affect the files contained within.

Copy link
Contributor

You are right. Thank you for reporting.

@jonz94
Copy link
Collaborator

jonz94 commented Feb 16, 2024

Thanks for the detailed information!

Now, installation scripts will directly download the zip file from GitHub, which should help avoid the hash check failed issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants