Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Namespace conflicts likely with MCStopProxy stop method #16

Open
pquimby opened this issue Jan 12, 2016 · 1 comment
Open

Namespace conflicts likely with MCStopProxy stop method #16

pquimby opened this issue Jan 12, 2016 · 1 comment

Comments

@pquimby
Copy link

pquimby commented Jan 12, 2016

I recently fixed a bug in my codebase caused by having the stop method injected via a category as a part of the MCANIMATE_SHORTHAND define. We have another class from a third-party source with a method name stop. It would be appreciated, since the MCStopProxy category injects into NSObject that is have a more unique name like stopAnimation to avoid any number of other uses of the method name stop.

@matthewcheok
Copy link
Owner

That's precisely why MCANIMATE_SHORTHAND exists - it provides convenience at a cost. Your suggestion does have merit though and I'd be happy take a PR :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants