Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MM-1028]: Fixed the issue of title being truncated without ellipses in tooltip modal #1123

Merged
merged 5 commits into from
Nov 12, 2024

Conversation

Kshitij-Katiyar
Copy link
Contributor

@Kshitij-Katiyar Kshitij-Katiyar commented Sep 20, 2024

Summary

  • Fixed the issue of the title being truncated without ellipses in the tooltip modal
    Added hover text for the tooltip title

Ticket Link

Fixes #1028
Fixes #1077

Screenshots

Title

Screenshot from 2024-09-20 11-15-21

Old

Screenshot from 2024-09-20 11-17-30

New

Screenshot from 2024-10-25 14-29-35

@raghavaggarwal2308 raghavaggarwal2308 added 2: Dev Review Requires review by a core committer 3: QA Review Requires review by a QA tester labels Sep 20, 2024
@raghavaggarwal2308 raghavaggarwal2308 added this to the v4.3.0 milestone Sep 20, 2024
Copy link
Member

@wiggin77 wiggin77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@wiggin77 wiggin77 removed the 2: Dev Review Requires review by a core committer label Sep 20, 2024
@AayushChaudhary0001
Copy link

@Kshitij-Katiyar While testing this PR, I found a minor issue related to extra spaces in the title in Jira issue.
If we try to add extra spaces in between the words of the title of a Jira issue, it is shown with proper spacing on Jira. But if we hover over the link of the same ticket on MM, then the text gets truncated as if the text length is too long. I am attaching the screenshot below, please take reference from those.

On adding extra spaces:-
image

On saving the title on Jira:-

image

On hovering on MM:-
image

@Kshitij-Katiyar
Copy link
Contributor Author

@Kshitij-Katiyar While testing this PR, I found a minor issue related to extra spaces in the title in Jira issue. If we try to add extra spaces in between the words of the title of a Jira issue, it is shown with proper spacing on Jira. But if we hover over the link of the same ticket on MM, then the text gets truncated as if the text length is too long. I am attaching the screenshot below, please take reference from those.

On adding extra spaces:- image

On saving the title on Jira:-

image

On hovering on MM:- image

Hey @AayushChaudhary0001, I created a similar ticket on JIra and checked the data sent by Jira to the MM server, it looks like the handling of the extra spaces between the words is on the client side of Jira and the data is stored on the server with the extra spaces only because we are receiving the ticket summary with the extra spaces on the MM server.
I am afraid there is no proper way to fix this issue

@raghavaggarwal2308
Copy link
Contributor

@Kshitij-Katiyar @AayushChaudhary0001 I think we should match the functionality of Jira here. If Jira is removing the extra spaces we should also do the same.

@Kshitij-Katiyar
Copy link
Contributor Author

@Kshitij-Katiyar @AayushChaudhary0001 I think we should match the functionality of Jira here. If Jira is removing the extra spaces we should also do the same.

@AayushChaudhary0001 @raghavaggarwal2308 I have implemented the same. Please re test it @AayushChaudhary0001

Copy link

@AayushChaudhary0001 AayushChaudhary0001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR has been tested for the above fix, LGTM. Approved.

@raghavaggarwal2308 raghavaggarwal2308 added 4: Reviews Complete All reviewers have approved the pull request and removed 3: QA Review Requires review by a QA tester labels Nov 12, 2024
@raghavaggarwal2308 raghavaggarwal2308 merged commit b54d4c6 into master Nov 12, 2024
9 checks passed
@raghavaggarwal2308 raghavaggarwal2308 deleted the MM-1028 branch November 12, 2024 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4: Reviews Complete All reviewers have approved the pull request
Projects
None yet
4 participants