-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MM-1028]: Fixed the issue of title being truncated without ellipses in tooltip modal #1123
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
@Kshitij-Katiyar While testing this PR, I found a minor issue related to extra spaces in the title in Jira issue. On saving the title on Jira:- |
Hey @AayushChaudhary0001, I created a similar ticket on JIra and checked the data sent by Jira to the MM server, it looks like the handling of the extra spaces between the words is on the client side of Jira and the data is stored on the server with the extra spaces only because we are receiving the ticket summary with the extra spaces on the MM server. |
@Kshitij-Katiyar @AayushChaudhary0001 I think we should match the functionality of Jira here. If Jira is removing the extra spaces we should also do the same. |
@AayushChaudhary0001 @raghavaggarwal2308 I have implemented the same. Please re test it @AayushChaudhary0001 |
webapp/src/components/jira_ticket_tooltip/jira_ticket_tooltip.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR has been tested for the above fix, LGTM. Approved.
Summary
Added hover text for the tooltip title
Ticket Link
Fixes #1028
Fixes #1077
Screenshots
Title
Old
New