Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explorer API reports proxy contracts incorrectly #264

Open
dasebek opened this issue Jun 24, 2024 · 1 comment
Open

Explorer API reports proxy contracts incorrectly #264

dasebek opened this issue Jun 24, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@dasebek
Copy link

dasebek commented Jun 24, 2024

🐛 Bug Report

📝 Description

The explorer API incorrectly reports that a proxy smart contract isn't a proxy.

Online block explorer reports that a proxy smart contract is a proxy:
https://explorer.zksync.io/address/0x5A7d6b2F92C77FAD6CCaBd7EE0624E64907Eaf3E#contract

But the explorer API reports that the same smart contract is NOT a proxy:
https://block-explorer-api.mainnet.zksync.io/api?module=contract&action=getsourcecode&address=0x5A7d6b2F92C77FAD6CCaBd7EE0624E64907Eaf3E

            "Proxy": "0",
            "Implementation": "",

🔄 Reproduction Steps

  1. Search for a proxy smart contract in the online explorer (https://explorer.zksync.io/). The explorer will show that the contract is a proxy.
  2. Search for the same smart contract via the API (https://block-explorer-api.mainnet.zksync.io/api). The response will indicate that the same contract is not a proxy.

🤔 Expected Behavior

The API response should indicate that the proxy smart contract is a proxy ("Proxy": "1"). It should also return the address of the implementation contract ("Implementation").

😯 Current Behavior

The API response indicates that the proxy smart contract is NOT a proxy ("Proxy": "0"). It also doesn't return any implementation contract address ("Implementation": "").

@dasebek dasebek added the bug Something isn't working label Jun 24, 2024
@dasebek
Copy link
Author

dasebek commented Aug 14, 2024

I can still reproduce the issue. Is there an ETA for a fix?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant