Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API Compatibility: getLogs requires an address, while Etherscan API doesn't #194

Open
kunalmodi opened this issue Mar 6, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@kunalmodi
Copy link

🐛 Bug Report

📝 Description

The Get Logs endpoint (https://block-explorer-api.mainnet.zksync.io/docs#/Logs%20API/ApiController_getLogs) requires an address. On the Etherscan family of APIs, address is optional (example query)

Querying without an address is useful when I'm looking for logs from proxy contracts, where the cardinality of contracts is extremely high (or maybe even unknown)

🔄 Reproduction Steps

Query I would have expected to work: https://block-explorer-api.mainnet.zksync.io/api?&module=logs&action=getLogs&offset=1000&fromBlock=12689376&toBlock=12788055&topic0=0x141df868a6331af528e38c83b7aa03edc19be66e37ae67f9285bf4f8e3c6a1a8

Currently throws: {"status":"0","message":"NOTOK","result":"Error! Invalid address format"}

🤔 Expected Behavior

😯 Current Behavior

🖥️ Environment

📋 Additional Context

@kunalmodi kunalmodi added the bug Something isn't working label Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant