Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Automatic Verification of Similar Child Contracts Post Initial Verification #106

Open
mshakeg opened this issue Nov 30, 2023 · 1 comment

Comments

@mshakeg
Copy link

mshakeg commented Nov 30, 2023

🌟 Feature Request

📝 Description

I would like to propose a feature for the zkSync block explorer that automatically verifies all instances of a child contract once the initial instance has been verified. Currently, on zkSync, each deployment of a child contract created by a factory contract requires individual verification. This process can be quite repetitive and time-consuming, especially for projects that frequently deploy new instances of the same contract e.g. a pool contract created by a pool factory.

🤔 Rationale

The rationale behind this feature is to streamline the developer experience and reduce the redundancy in the contract verification process. On Etherscan, once a contract is verified, all subsequent deployments of the same contract (with the same bytecode) are automatically recognized and marked as verified. This approach significantly eases the burden on developers, as they don’t need to repeatedly verify each instance of a contract that has already been verified once. Adopting a similar feature in the zkSync block explorer would greatly enhance usability and efficiency, particularly for projects involving factory patterns or multiple deployments of identical contracts.

📋 Additional Context

This feature would be particularly beneficial in environments where contracts are frequently cloned or deployed en masse, such as in DeFi projects, NFT collections, or any other application utilizing factory contracts for creating multiple instances of the same contract. The current requirement to verify each deployed instance separately can act as a bottleneck and deter developers from utilizing zkSync to its full potential. Implementing this feature would align zkSync's developer tools more closely with industry standards and improve its overall attractiveness as a Layer 2 solution.

@jaguard2021
Copy link

Improving automation certainly brings benefits, but it's also important to understand its impact on the overall performance of the platform. Is there a potential increase in workload or a decrease in performance with the addition of these features?

How can these features affect projects that may have different verification needs? It's important to understand the overall impact on the ecosystem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants