Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load more and redundant subscriptions #150

Open
kk4sh opened this issue Feb 21, 2015 · 4 comments
Open

Load more and redundant subscriptions #150

kk4sh opened this issue Feb 21, 2015 · 4 comments

Comments

@kk4sh
Copy link

kk4sh commented Feb 21, 2015

Hi,
Is it possible to avoid the unsubscription of the current results when using load more?
Currently, all results are unsub then sub again with the larger set.

@matteodem
Copy link
Owner

How would you want to avoid that? And why? This way it only takes the least amount of docs required to the client.

@kk4sh
Copy link
Author

kk4sh commented Feb 22, 2015

The use case is the 'load more' used as pagination.

Load more should just add new subscriptions ( the next results) but keep the previous ones.

Current behavior: the previous results subscriptions are stopped and the new subscriptions are done for the previous docs plus the new ones.
Awaiting behavior: subscribe only for the new results and dont unsub the previous ones.

The aim is to keep the curent results available even if a search runs (cause of load more activation for ie) .
The available subscribed items are kept and the loading process dont flush the entire results set.

Ofc, the final amont client side docs stays the same.

See the https://www.youtube.com/watch?v=FUTuLM-0hMI at 3:50, typically what i want to reproduced.

Hope it is clear enough.

@tinchoz49
Copy link

👍

@matteodem
Copy link
Owner

As I can't see that this has any impact on the UI (tested with https://github.com/matteodem/easy-search-leaderboard) I'll leave this open for people to submit PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants