Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Log level OFF (JUL) is mapped to ERROR (SLF4J) #22

Closed
joschi opened this issue Nov 26, 2024 · 2 comments
Closed

Bug: Log level OFF (JUL) is mapped to ERROR (SLF4J) #22

joschi opened this issue Nov 26, 2024 · 2 comments

Comments

@joschi
Copy link
Contributor

joschi commented Nov 26, 2024

Slf4jLogger#log(Level, String, Throwable) doesn't handle Level.OFF from java.util.logging and logs the respective messages on ERROR level instead.

https://github.com/mattbertolini/liquibase-slf4j/blob/v5.1.0/src/main/java/com/mattbertolini/liquibase/logging/slf4j/Slf4jLogger.java#L79-L92

@mattbertolini
Copy link
Owner

Hi @joschi. I think this was reported last week in #20 and that reporter confirmed it was fixed with PR #21. I released version 5.1.0 with this change. Is there another failure case I am unaware of that is still triggering?

@joschi
Copy link
Contributor Author

joschi commented Nov 26, 2024

You're right. I stumbled over it in context of dropwizard/dropwizard#9604 but that was still with liquibase-slf4j 5.0.0.

The linked PR which ended up in v5.1.0 should fix this. 😄

@joschi joschi closed this as completed Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants