Skip to content
This repository has been archived by the owner on Sep 16, 2024. It is now read-only.

Support using MATRIX_BOT_PASSWORD without MATRIX_ACCESS_TOKEN #258

Open
aine-etke opened this issue Dec 23, 2023 · 6 comments
Open

Support using MATRIX_BOT_PASSWORD without MATRIX_ACCESS_TOKEN #258

aine-etke opened this issue Dec 23, 2023 · 6 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@aine-etke
Copy link

Hello,

Please add a way to support password-only login, without the requirement to manually set MATRIX_ACCESS_TOKEN.
The bot could generate the token as it does it right now, but store it somewhere (e.g., in the DATA_PATH) to use it automatically later, without needing to adjust env vars manually

@bertybuttface
Copy link
Collaborator

This is likely a feature request presumably for your paid product ($3 monthly fee for hosted instance of this bot).

I fully support you offering a paid instance of this service (and I've added a link in our chat room to your service) as per your rights under the GPL v3.0 which I didn't select but chose to keep in place when rewriting the codebase.

Would you consider adding this feature and contributing it back to the community under the GPL v3.0 license?

@aine-etke
Copy link
Author

aine-etke commented Feb 19, 2024

At etke.cc we offer unmodified versions of open-source software, and our product isn't a bot instance, but the expertise of our developers to configure and maintain servers. Moreover, everything we do is entirely open source under A/GPL-3.0, so we contribute to the community with every single change we do, be it for commercial purposes, or for our internal needs.

Unfortunately, I don't have enough knowledge to implement that feature; otherwise I'd send a PR with an implementation like this one without creating an issue 😄

@bertybuttface
Copy link
Collaborator

bertybuttface commented Feb 19, 2024

A running instance of course requires configuration and maintenance, apologies for not explicitly stating this.

Please don't think I'm calling you out, I love the fact this code is being used in an actual product. It is good for everyone.

That said there are features I'd like in tools like Postmoogle (e.g. IMAP support) but that would require paid development services (https://etke.cc/services/customdev) to be implemented.

As neither myself nor anyone else so far has requested this feature I'm going to have to ask you guys to pay for custom development or write the feature yourselves. Either that or wait until myself or someone else needs the feature and develops it themselves.

@aine-etke
Copy link
Author

That said there are features I'd like in tools like Postmoogle (e.g. IMAP support) but that would require paid development

Sorry for the confusion, but none of them requires paid development. The whole purpose of the Custom Development is stated on the linked page, in the into section:

Of course, you can just create an issue in a project’s repository to request a new feature and get it implemented, if we will find it useful for our services or if someone from the open-source community will implement it and send an MR with the requested feature.
But if you want to get that feature for sure and not rely on our and community good will, you can pay the project developers to implement that feature.

I apologize if the description is not clear, the intended meaning is: anyone could create an issue to request a feature, but don't expect that request has to be fulfilled (the same way this issue is created - hoping someone will be interested in implementing it). If anyone is interested in implementing that request, they will send an MR with implementation, but if you don't want to wait or rely on that - you could order project developers to implement it for you as a paid development. Nonetheless, the results of that development will be published under A/GPL-3.0 license in the project's repo.

So, to summarize: the custom development service is an additional option, it does not limit or prevent feature implementation. Specifically for IMAP support - that's a wonderful idea for Postmoogle, but we at etke.cc don't need it, and we don't have resources to implement it "just for fun". So, if anyone would like to send an MR with implementation - we'll be glad to review and include it

@bertybuttface
Copy link
Collaborator

bertybuttface commented Feb 19, 2024

Perfect cheers, I appreciate you taking the time to explain.

Unfortunately I am also resource constrained so I don't really maintain this bot much myself any more, I accept PRs and keep packages up to date but that is about it.

This feature request should be considered very much in the same state as the IMAP feature request for Postmoogle. I agree that it is something nice to have but I just can't spend the time on implementing it.

More than happy to accept a PR or to discuss custom development at a cost if this feature is important to you and having it would save significant setup time / headaches for your staff.

@bertybuttface bertybuttface added help wanted Extra attention is needed good first issue Good for newcomers and removed bug Something isn't working labels Feb 19, 2024
@aine-etke
Copy link
Author

I'm glad the explanation cleared the confusion!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants