Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Add avatar and topic settings for server notice room #16679

Merged
merged 12 commits into from
Dec 12, 2023

Conversation

MatMaul
Copy link
Contributor

@MatMaul MatMaul commented Nov 23, 2023

Signed-off-by: Mathieu Velten [email protected]

Pull Request Checklist

@github-actions github-actions bot deployed to PR Documentation Preview November 23, 2023 13:54 Active
@MatMaul MatMaul force-pushed the server-notice-room-avatar branch from 12fdf1e to 3721e42 Compare November 23, 2023 13:54
@github-actions github-actions bot deployed to PR Documentation Preview November 23, 2023 13:55 Active
@MatMaul MatMaul force-pushed the server-notice-room-avatar branch from 3721e42 to 97f21a1 Compare November 23, 2023 15:34
@github-actions github-actions bot deployed to PR Documentation Preview November 23, 2023 15:35 Active
@MatMaul MatMaul force-pushed the server-notice-room-avatar branch from 97f21a1 to e4fd112 Compare November 23, 2023 15:57
@github-actions github-actions bot deployed to PR Documentation Preview November 23, 2023 15:58 Active
@MatMaul MatMaul force-pushed the server-notice-room-avatar branch from e4fd112 to 366681b Compare November 23, 2023 16:59
@github-actions github-actions bot deployed to PR Documentation Preview November 23, 2023 17:00 Active
@MatMaul MatMaul force-pushed the server-notice-room-avatar branch from 366681b to 645223c Compare November 23, 2023 18:30
@github-actions github-actions bot deployed to PR Documentation Preview November 23, 2023 18:31 Active
@MatMaul MatMaul force-pushed the server-notice-room-avatar branch from 645223c to 74ca230 Compare November 28, 2023 15:07
@MatMaul MatMaul marked this pull request as ready for review November 28, 2023 15:08
@MatMaul MatMaul requested a review from a team as a code owner November 28, 2023 15:08
@DMRobertson
Copy link
Contributor

I left some thoughts, but had to stop before I got to _update_room_info.

@DMRobertson DMRobertson requested a review from a team December 6, 2023 15:38
Copy link
Member

@erikjohnston erikjohnston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some minor nits

synapse/server_notices/server_notices_manager.py Outdated Show resolved Hide resolved
synapse/server_notices/server_notices_manager.py Outdated Show resolved Hide resolved
synapse/server_notices/server_notices_manager.py Outdated Show resolved Hide resolved
changelog.d/16679.feature Outdated Show resolved Hide resolved
@MatMaul MatMaul requested a review from erikjohnston December 12, 2023 14:11
@erikjohnston erikjohnston merged commit e108c31 into matrix-org:develop Dec 12, 2023
40 checks passed
@erikjohnston
Copy link
Member

Thanks ❤️

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants