This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Add avatar and topic settings for server notice room #16679
Merged
erikjohnston
merged 12 commits into
matrix-org:develop
from
MatMaul:server-notice-room-avatar
Dec 12, 2023
Merged
Add avatar and topic settings for server notice room #16679
erikjohnston
merged 12 commits into
matrix-org:develop
from
MatMaul:server-notice-room-avatar
Dec 12, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MatMaul
force-pushed
the
server-notice-room-avatar
branch
from
November 23, 2023 13:54
12fdf1e
to
3721e42
Compare
MatMaul
force-pushed
the
server-notice-room-avatar
branch
from
November 23, 2023 15:34
3721e42
to
97f21a1
Compare
MatMaul
force-pushed
the
server-notice-room-avatar
branch
from
November 23, 2023 15:57
97f21a1
to
e4fd112
Compare
MatMaul
force-pushed
the
server-notice-room-avatar
branch
from
November 23, 2023 16:59
e4fd112
to
366681b
Compare
MatMaul
force-pushed
the
server-notice-room-avatar
branch
from
November 23, 2023 18:30
366681b
to
645223c
Compare
MatMaul
force-pushed
the
server-notice-room-avatar
branch
from
November 28, 2023 15:07
645223c
to
74ca230
Compare
MatMaul
force-pushed
the
server-notice-room-avatar
branch
from
November 28, 2023 15:24
74ca230
to
3bcfe96
Compare
clokep
reviewed
Nov 29, 2023
DMRobertson
reviewed
Dec 6, 2023
DMRobertson
reviewed
Dec 6, 2023
DMRobertson
reviewed
Dec 6, 2023
DMRobertson
reviewed
Dec 6, 2023
DMRobertson
reviewed
Dec 6, 2023
I left some thoughts, but had to stop before I got to |
Co-authored-by: David Robertson <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some minor nits
Co-authored-by: Erik Johnston <[email protected]>
Co-authored-by: Erik Johnston <[email protected]>
Thanks ❤️ |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Mathieu Velten [email protected]
Pull Request Checklist
(run the linters)