Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not disabling the send queue when an event is wedged breaks the expectations of users #4389

Open
zecakeh opened this issue Dec 8, 2024 · 2 comments

Comments

@zecakeh
Copy link
Collaborator

zecakeh commented Dec 8, 2024

If the error is temporary, the send queue is disabled, so the events are sent in the right order, which makes sense. However it is not disabled in case of a "permanent" error, the event is marked as wedged and the following events are sent.

A user opened an issue on Fractal, surprised by this behavior (among other things).

It seems logical that a user would expect their events to be sent in the right order or not at all, whether the error is permanent or not. It should be their choice whether they want to remove an event or several from the send queue, or all of them, due to the first one failing to send, to avoid losing context in the conversation.

According to the issue, this is already the behavior of EW.

@bnjbvr
Copy link
Member

bnjbvr commented Dec 9, 2024

Thanks for opening an issue here. Indeed, it might be confusing for the user, although it's also likely an edge case in the sense that an interleaving of wedged and not-wedged send requests is a bit surprising (but can happen, as proves the fractal issue). I'll discuss this internally, in the meanwhile feel free to add a boolean setting to the send queue: when it's enabled, a permanent failure would also disable the room's queue.

@bnjbvr bnjbvr self-assigned this Dec 18, 2024
@bnjbvr
Copy link
Member

bnjbvr commented Dec 18, 2024

Confirmed that we do want the send queues to be blocked in that case too. Thanks for bringing this up Kevin!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants