Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release process bugs #4292

Open
3 tasks
poljar opened this issue Nov 19, 2024 · 2 comments
Open
3 tasks

Release process bugs #4292

poljar opened this issue Nov 19, 2024 · 2 comments

Comments

@poljar
Copy link
Contributor

poljar commented Nov 19, 2024

@bnjbvr
Copy link
Member

bnjbvr commented Nov 19, 2024

The ffi-macros crate is used if the uniffi feature is set, right? So technically we do have to ship it, even though we don't ship the bindings, as long as we have the uniffi feature 🤔

@poljar
Copy link
Contributor Author

poljar commented Nov 19, 2024

Well yes, that's what this issue is about, I released the macros crate manually this time around.

Though we can do a couple of things to fix this issue:

  1. Get rid of the dep.
  2. Add the ffi-macros to our release process.
  3. Upstream the feature the macro provides to uniffi.

@poljar poljar changed the title The matrix-sdk crate depends on the matrix-sdk-ffi-macros crate Release process bugs Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants