-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce runtime.ForMatrixVersion
#549
Comments
Is the assumption here that I'm unsure if that's valid. |
Do you think specifying an upper bound (for when a feature is deprecated) is needed? |
For what we have today, probably not. I guess we could always handle that in the future. |
Closing this. We want to move away from Complement dictating what tests are run. Whilst I like the idea of having Complement self-configure itself, it could also be a bit of a nightmare. If |
Related to #335, and as a related alternative to what I was trying to do in #242;
Introduce
runtime.ForMatrixVersion(major, minor uint8)
, which will fetch/client/versions
and compare if the given version is compatible with any version given.If not, skip the test.
This'd make it possible for complement to skip whole hosts of tests automatically if the server does not broadcast support for it.
It would also self-document the feature prescribing itself only for/after a certain matrix version, which would help with sorting through them at a later time.
In the future, it could also be possible to do the same for MSCs (via `unstable_features matching, and such)
The text was updated successfully, but these errors were encountered: