Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

graphicsmagic poop: iCCP: known incorrect sRGB profile #153

Open
grinapo opened this issue May 22, 2020 · 2 comments
Open

graphicsmagic poop: iCCP: known incorrect sRGB profile #153

grinapo opened this issue May 22, 2020 · 2 comments
Labels
bug Something isn't right. cause unknown The root of the problem is not identified or sufficiently understood to fix.

Comments

@grinapo
Copy link

grinapo commented May 22, 2020

got a lot of these

2020/05/22 18:57:47.354269 13885139  WARNING magick          53 client     :job:55028 0/1 [Loading image: 256x256...  ] (#350)  :iCCP: known incorrect sRGB profile :
2020/05/22 18:57:47.355793 13885139  WARNING magick          53 client     :job:55032 0/1 [Loading image: 21x21...  ] (#350)  :iCCP: known incorrect sRGB profile :
2020/05/22 18:58:16.529665 13889291  WARNING magick          94 client     :job:55311 6/7 [Loading image: 264x384...  ] (#350)  :iCCP: known incorrect sRGB profile :
2020/05/22 18:58:16.534567 13889291  WARNING magick          94 client     :job:55315 0/1 [Loading image: 54x78...  ] (#350)  :iCCP: known incorrect sRGB profile :
@jevolk jevolk added bug Something isn't right. cause unknown The root of the problem is not identified or sufficiently understood to fix. labels May 22, 2020
@jevolk
Copy link
Member

jevolk commented May 22, 2020

Thanks. These are classified as non-error warnings by graphicsmagick itself and I don't believe the functionality is impacted, though I'm not entirely sure. I believe the cause is the source media downloaded from the remote server.

Unless these messages are truly spamming the WARNING log level it's probably best to not demote them to DWARNING. I'm leaving this open so more can be learned about these messages and if anything can be done to mitigate the issue.

@grinapo
Copy link
Author

grinapo commented May 23, 2020

For all intents and purposes of a matrix server the message is harmless (and useless): it notifies us that the color space of the original is fucked and whatever we do about (eg. convert it or resize it) it will result a similarly fucked up color space, eg. the image will not have perfect colors, just as the original.

It is not an annoying amount right now but probably should not be shown later in the final version, since it's rather a DEBUG level message. For now it's okay (I just didn't have them because graphicsmagic wasn't installed).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't right. cause unknown The root of the problem is not identified or sufficiently understood to fix.
Projects
None yet
Development

No branches or pull requests

2 participants