Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

missing package-lock.json #19

Open
uninsane opened this issue Oct 21, 2023 · 0 comments · May be fixed by #20
Open

missing package-lock.json #19

uninsane opened this issue Oct 21, 2023 · 0 comments · May be fixed by #20

Comments

@uninsane
Copy link

would you consider committing the package-lock.json file to the repo? npm docs suggest to do this and it eases the burden for downstream consumers by publishing a known-good dependency configuration.

i understand this project is considered "legacy" at this point, but in a way that makes having a lockfile even more useful since breakages caused by new dependency releases are more liable to go unnoticed here.

@dotlambda dotlambda linked a pull request Nov 3, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant