-
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimist actions are not FSA-compliant #2
Comments
Lol I came here to suggest the same thing! Pressed for time now, but I may come back later to work on a PR to change this. Should be a simple change, right? |
@mathieudutour Closed without comment? Why? |
I fixed it in 0.2.1, you now specify the optimist in meta:
I'm working on a better doc. |
Wow that's great @mathieudutour 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
From flux-standard-action:
The redux-optimist project is really proposing an extension to the FSA spec (which is under discussion). You have the
isFSA
check, but it would actually fail if you put theoptimist
flag on an action. Your tests don't currently seem to cover that case though. So you either shouldn't claim to be FSA-compliant yet, or you should move the optimist flag tometa
for the time being.The text was updated successfully, but these errors were encountered: