Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comparing residuals #350

Open
dgm2 opened this issue Oct 1, 2024 · 4 comments
Open

Comparing residuals #350

dgm2 opened this issue Oct 1, 2024 · 4 comments
Labels
help wanted Extra attention is needed

Comments

@dgm2
Copy link

dgm2 commented Oct 1, 2024

The 2D residuals, for example for the wave problem (tutorial3), can have positive and negative color-bar values.
In order to compare multiple approaches with the same color-bar, should I take the absolute values, and then see where is lowest?
thanks!

@dgm2 dgm2 added the help wanted Extra attention is needed label Oct 1, 2024
@dario-coscia
Copy link
Collaborator

Hi @dgm2! There is not a unique metric to assess the quality of the solution. Usually, one computes the $L_2$ norm (see here) of the residual for different methodologies and see which one archives the lowest. However, it depends on your specific problem and what you want to check👍🏻

@dgm2
Copy link
Author

dgm2 commented Oct 2, 2024

My question is how to compare multiple residuals via the plot as you have in tutorial2 and tutorial3. The issue with current code is that the residuals can be positive or negative on the colorbar. I am wondering, a negative value is always better than a positive one? or we should consider their absolute values?

@dario-coscia
Copy link
Collaborator

The "best" value is when the residual is zero, so a very negative value is as bad as a very positive value. To assess which model is better you can look at the axis, the best model is the one with the colorbar values closer to zero.

@dario-coscia
Copy link
Collaborator

dario-coscia commented Nov 20, 2024

Hi @dgm2! Can I close the issue, were you able to compare different pinns? We are preparing a tutorial exactly for that, stay tuned!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants