Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimizer and Scheduler #342

Open
ndem0 opened this issue Sep 9, 2024 · 0 comments
Open

Optimizer and Scheduler #342

ndem0 opened this issue Sep 9, 2024 · 0 comments
Labels
question Further information is requested v0.2 implementation in v0.2

Comments

@ndem0
Copy link
Member

ndem0 commented Sep 9, 2024

          I really like both `Optimizer` and `Scheduler` classes! I think the `hook` method can be made an abstract method for the base classes. In this way all the classes that inherit from those need to have this function (which is fundamental to attach the network parameters to optimize).

The only thing that I am concerned about is the back compatibility with Lightning, as by default Lightning will use built-in functions inherited from Torch Optimizers and Schedulers. Maybe in the base classes Optimizer and Scheduler we should inherit from torch base classes of optimizer and scheduler as well?

Originally posted by @dario-coscia in #312 (comment)

@ndem0 ndem0 added question Further information is requested v0.2 implementation in v0.2 labels Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested v0.2 implementation in v0.2
Projects
None yet
Development

No branches or pull requests

1 participant