Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conditions #341

Open
ndem0 opened this issue Sep 9, 2024 · 0 comments
Open

Conditions #341

ndem0 opened this issue Sep 9, 2024 · 0 comments
Labels
question Further information is requested v0.2 implementation in v0.2

Comments

@ndem0
Copy link
Member

ndem0 commented Sep 9, 2024

I agree to divide conditions in multiple classes but I do not think that the residual method should be inside conditions. I see conditions more like an object that encapsulates data, if we constrain also to what the model should do we can't cover all test cases. I think that the loss to minimize should be defined only inside the solver (physics-informed, data-driven whatever), in this way is user responsibility to know how to use the data

Maybe we can think more of something like PhysicsConditions, DataConditions, GraphConditions (like the division in the dataloading)... These conditions are needed to call loss_data, loss_phys, and loss_graph (which are defined inside the solver). This helps us to do two things:

  1. We know which functions need to be defined in the solver by looking at the conditions the problem has (we can raise errors before training)
  2. We don't need to cover all classes of possible ways residuals are defined, we only need to pass the data that are needed to compute it.

Originally posted by @dario-coscia in #312 (comment)

@ndem0 ndem0 added question Further information is requested v0.2 implementation in v0.2 labels Sep 9, 2024
@dario-coscia dario-coscia mentioned this issue Oct 4, 2024
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested v0.2 implementation in v0.2
Projects
None yet
Development

No branches or pull requests

1 participant