Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Propagation of FWAction's only happens for last Firetask in Firework #431

Open
utf opened this issue Jan 6, 2021 · 0 comments
Open

Propagation of FWAction's only happens for last Firetask in Firework #431

utf opened this issue Jan 6, 2021 · 0 comments

Comments

@utf
Copy link
Member

utf commented Jan 6, 2021

The FWAction.propagate option (see #407) only takes effect if the FWAction is from the last Firetask in the Firework, otherwise it is ignored, due to the way FWActions are amalgamated.

E.g. the code surrounding:

all_mod_spec.extend(m_action.mod_spec)

One fix would be to make the amalgamated FWAction propagate if ANY of the previous FWAction's had propagate=True. Other than that, I don't see an easy fix without completely rewriting the way FWActions are applied.

Tagging @jotelha in case they have any ideas.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant