You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The FWAction.propagate option (see #407) only takes effect if the FWAction is from the last Firetask in the Firework, otherwise it is ignored, due to the way FWActions are amalgamated.
One fix would be to make the amalgamated FWAction propagate if ANY of the previous FWAction's had propagate=True. Other than that, I don't see an easy fix without completely rewriting the way FWActions are applied.
The
FWAction.propagate
option (see #407) only takes effect if the FWAction is from the last Firetask in the Firework, otherwise it is ignored, due to the way FWActions are amalgamated.E.g. the code surrounding:
fireworks/fireworks/core/rocket.py
Line 322 in 32b1ea9
One fix would be to make the amalgamated FWAction propagate if ANY of the previous FWAction's had
propagate=True
. Other than that, I don't see an easy fix without completely rewriting the way FWActions are applied.Tagging @jotelha in case they have any ideas.
The text was updated successfully, but these errors were encountered: