Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Monaco loader fails when Electron Node integration is off #84

Open
bundyo opened this issue Jan 20, 2022 · 1 comment
Open

Monaco loader fails when Electron Node integration is off #84

bundyo opened this issue Jan 20, 2022 · 1 comment
Labels
enhancement New feature or request

Comments

@bundyo
Copy link

bundyo commented Jan 20, 2022

Loading Monaco Editor in Electron with Node integration off results in a crash, when it tries to access Node require. This is the default option in VSCode Loader, but there is another not documented require.config option preferScriptTags, that switches the default behavior to load scripts through the renderer.

Unfortunately at this time, this config is hidden behind your MonacoEditorLoaderService's loadMonaco method and making it work is not easy. Can you somehow allow passing config options to the VSCode Loader's config method?

@jmarc-roy jmarc-roy added the enhancement New feature or request label Jan 26, 2022
@jmarc-roy
Copy link
Collaborator

Hi @bundyo!

Thanks for the suggestion.
Will take a look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants