Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Get purchasing fans from album URL #6

Open
mrdavemorgan opened this issue Feb 15, 2017 · 12 comments
Open

Feature request: Get purchasing fans from album URL #6

mrdavemorgan opened this issue Feb 15, 2017 · 12 comments

Comments

@mrdavemorgan
Copy link

Readme says "Contribution is welcome! Open an issue first." So ...

I'm doing some work to retrieve fans who have purchased an album. If this feature is useful I can do a pull request. Thanks.

@masterT
Copy link
Owner

masterT commented Feb 15, 2017

Hi @mrdavemorgan,

Yes I agree this can be useful, PR welcome! 😃

@masterT
Copy link
Owner

masterT commented Feb 15, 2017

I suggest you to return the additional info in the getAlbumInfo. You'll also need to update the JSON schema.

@mrdavemorgan
Copy link
Author

The fan list returned can be rather large (see this example). If you don't think that's too much, then I'll insert it into the album info as suggested.

@masterT
Copy link
Owner

masterT commented Feb 16, 2017

Well it's huge! It'll be ok if it has its own function!

@masterT
Copy link
Owner

masterT commented Jan 15, 2018

@mrdavemorgan What's up with this feature?

@mrdavemorgan
Copy link
Author

Had a proof of concept, but nothing clean enough to submit. Got sidetracked with some other projects, but I'll see what I can do this week.

@masterT
Copy link
Owner

masterT commented Jan 16, 2018

Awesome 👍😊

@mrdavemorgan
Copy link
Author

The page format has changed a lot since I last touched it, so it will take a bit of work to get it working again.

@abetusk
Copy link

abetusk commented Sep 26, 2019

I would also like this feature. @mrdavemorgan any chance on sharing what you have so far?

@pawling11
Copy link

Hi @masterT
I'd like to take up this feature.

@masterT
Copy link
Owner

masterT commented Apr 21, 2020

Hi, that would be nice! 😃 I think it has been forgotten.

@pawling11
Copy link

Great! I spent some time looking through the code the other night. I'll continue to do this in my spare time, but I'll check back in if i have questions or when I'm ready to open a PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants