Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image JS Cross-Origin #20

Open
ReDrUm opened this issue Jul 11, 2014 · 1 comment
Open

Image JS Cross-Origin #20

ReDrUm opened this issue Jul 11, 2014 · 1 comment

Comments

@ReDrUm
Copy link
Contributor

ReDrUm commented Jul 11, 2014

Recently changes to ImageLoader added a crossOrigin property to generated ImageElements in JS target HTML (e.g. when used by mui.display.Image).

It's currently on by default and you're able to opt out by adding a compilation flag to your project:

-D default_cross_origin

Many third party image hosts/services don't yet support this and you're forced to add the flag to your project otherwise loading their images are blocked. Additionally if your app is loading images off multiple third party servers it's possible that some may need the crossOrigin property set while others won't.

I propose we change it to be opt-in instead of opt-out, and also set it at the class level instead of globally.

@dpeek
Copy link
Contributor

dpeek commented Jul 11, 2014

This was made opt-in so as not to break backward compatibility (someone actually submitted this change as a pull request, so I guess someone is using it at least...)

We'll need to do a major version bump to make the change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants