Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Circular dependencies with munit #43

Open
gene-pavlovsky opened this issue May 29, 2018 · 1 comment
Open

Circular dependencies with munit #43

gene-pavlovsky opened this issue May 29, 2018 · 1 comment

Comments

@gene-pavlovsky
Copy link

gene-pavlovsky commented May 29, 2018

It feels wrong that munit and mcover list each other as dependencies. If they are so tightly coupled, they should be a single library.
If those dependencies are optional, then it shouldn't be required to have one when requesting to install only the other one.

@elsassph
Copy link
Contributor

elsassph commented May 29, 2018

AFAIK the only use of munit is in the results connector so technically this dependency could be removed from haxelib.json:
https://github.com/massiveinteractive/mcover/tree/master/src/mcover/coverage/munit/client

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants