Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow transfers to SC addresses #4789

Merged
merged 2 commits into from
Dec 16, 2024
Merged

Allow transfers to SC addresses #4789

merged 2 commits into from
Dec 16, 2024
+113 −41

Conversation

Leo-Besancon
Copy link
Collaborator

@Leo-Besancon Leo-Besancon commented Dec 12, 2024 •
edited
Loading

  • document all added functions
  • try in sandbox /simulation/labnet
    • if part of node-launch, checked using the resync_check flag
  • unit tests on the added/changed features
    • make tests compile
    • make tests pass
  • add logs allowing easy debugging in case the changes caused problems
  • if the API has changed, update the API specification

Note: breaking change, will need to get versioned

@Leo-Besancon Leo-Besancon linked an issue Dec 12, 2024 that may be closed by this pull request
Allow direct transfers to SC addresses #4788
Closed
@Leo-Besancon Leo-Besancon marked this pull request as ready for review December 12, 2024 16:56
@Leo-Besancon Leo-Besancon requested review from sydhds and damip December 12, 2024 16:56
@Leo-Besancon Leo-Besancon mentioned this pull request Dec 12, 2024
Draft
4 tasks
@Leo-Besancon Leo-Besancon merged commit c16701a into mainnet_2_3 Dec 16, 2024
24 checks passed
@Leo-Besancon Leo-Besancon deleted the allow_transfers_to_sc_addresses branch December 16, 2024 14:56
Leo-Besancon added a commit that referenced this pull request Dec 16, 2024
@Leo-Besancon
Allow transfers to SC addresses (#4789)
faa8521 
* Allow transfers to SC

* Add unit test for 4 scenarios
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@damip damip damip approved these changes

@sydhds sydhds sydhds approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow direct transfers to SC addresses
3 participants
@Leo-Besancon @sydhds @damip