Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Header, Layout 컴포넌트 추가 #41

Merged
merged 13 commits into from
Feb 14, 2022
Merged

Conversation

mango906
Copy link
Member

@mango906 mango906 commented Feb 12, 2022

변경사항

  • 헤더 컴포넌트 추가
  • Layout 컴포넌트 추가해서 전역적으로 페이지에서 헤더가 뜨도록 추가

image

Link + emotion props 관련해서 이슈가 있는데 #42 이슈로 남겨두었습니다.

###TODO

작업 유형

  • 신규 기능 추가

체크리스트

  • Merge 할 브랜치가 올바른가?
  • 코딩컨벤션을 준수하였는가?
  • 해당 PR과 관련없는 변경사항이 없는가? (만약 있다면 제목이나 변경사항에 기술하여 주세요.)
  • 실행시 console 창에 에러나 경고가 없는것을 확인하였는가? (개발에 필요하여 고의적으로 남겨둔것 제외)

@mango906 mango906 requested a review from dididy as a code owner February 12, 2022 19:23
@mango906 mango906 self-assigned this Feb 12, 2022
@netlify
Copy link

netlify bot commented Feb 12, 2022

✔️ Deploy Preview for affectionate-jones-aa31c6 ready!

🔨 Explore the source changes: ab2cd54

🔍 Inspect the deploy log: https://app.netlify.com/sites/affectionate-jones-aa31c6/deploys/620a878f79980b00078afa48

😎 Browse the preview: https://deploy-preview-41--affectionate-jones-aa31c6.netlify.app

@mango906 mango906 requested a review from dididy February 14, 2022 12:29
Copy link
Member

@dididy dididy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 👍

Copy link
Member

@minsour minsour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mango906 mango906 merged commit afe2dca into feature/user-profile Feb 14, 2022
@dididy
Copy link
Member

dididy commented Feb 16, 2022

@mango906 현재 base를 feature/user-profile로 두고 머지되어서 develop에서 feature/header를 다시 머지해서 푸시해뒀습니다!

@dididy dididy deleted the feature/header branch February 21, 2022 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants