Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #185 (Large messages can clog ReliableOrderedChannel indefinitely). #186

Merged
merged 3 commits into from
Dec 24, 2023
Merged

Fixes #185 (Large messages can clog ReliableOrderedChannel indefinitely). #186

merged 3 commits into from
Dec 24, 2023

Conversation

sherief
Copy link
Contributor

@sherief sherief commented Nov 1, 2022

No description provided.

Pantong51
Pantong51 reviewed Jan 23, 2023
View reviewed changes
Copy link

@Pantong51 Pantong51 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've used this change in my own project as well

@dbechrd
Copy link
Contributor

dbechrd commented Nov 16, 2023

I've added some context to the issue (#185) and submitted my own PR (#193) that I think is a slightly safer way to detect this. Would love to hear thoughts from @sherief if I overlooked something.

@gafferongames gafferongames merged commit 3aebe70 into mas-bandwidth:master Dec 24, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pantong51 Pantong51 Pantong51 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sherief @dbechrd @Pantong51 @gafferongames