You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
How about exporting of class instead of already created instance here?
Some kind of
module.exports=rcswitch.RCSwitch;
I understand that this appear to be a compatibility breaking update, so we can think of another exporting way or making of major version bump.
Let me clarify why it's important.
Sometimes it's good to have different instances of RcSwitch for different purposes. It may be very useful especially alongside the code receiving. In rcswitch there is a disabling of receiving while transmitting data, so theoretically it should work simultaneously. But in fact there are some issues with receiving after transmission. I didn't dig much in that problem cause:
It works perfectly with 2 instances of RcSwitch anyway.
We don't need to stop receiving at all cause we're using different PINs for sending and receiving.
The text was updated successfully, but these errors were encountered:
Well, I think I found the reason for breaking of signal receiving after transmitting. First off, that happends when the rcswitch is disabling/enabling receiving while transmitting. I've described details here for rc-switch repo.
insolite
added a commit
to insolite/node-rcswitch2
that referenced
this issue
Jan 11, 2018
How about exporting of class instead of already created instance here?
Some kind of
I understand that this appear to be a compatibility breaking update, so we can think of another exporting way or making of major version bump.
Let me clarify why it's important.
Sometimes it's good to have different instances of
RcSwitch
for different purposes. It may be very useful especially alongside the code receiving. Inrcswitch
there is a disabling of receiving while transmitting data, so theoretically it should work simultaneously. But in fact there are some issues with receiving after transmission. I didn't dig much in that problem cause:RcSwitch
anyway.The text was updated successfully, but these errors were encountered: