Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move config templates to var #81

Closed

Conversation

JensHeinrich
Copy link

Fixes #79

@JensHeinrich
Copy link
Author

This is a try for now, but it works

Basically:

  • Move config templates into a variable
  • Move the variables into reusable env-files in the project root

@JensHeinrich
Copy link
Author

An alternative could be to make one Dockerfile and use targets

@jacksgt
Copy link
Collaborator

jacksgt commented Jul 23, 2021

Hey, thanks for the effort.

I'm not really onboard with this change, but maybe I don't just don't understand the use case.
In my opinion, environment variables should be a simple as possible -- in the end they are just key-value strings, and should be treated as such.
If there is a need to dynamically entire files into the container, please use a Kubernetes configmap, Docker configs or simply mount a file into the container.

@JensHeinrich
Copy link
Author

It was basically just my first idea on how to reduce the repeated code in the entrypoint.sh by moving the "templates" from a repeating hardcoded block in the shell files to the docker-compose files first (to be moved into a .env file shared by all yaml files

@martialblog suggested better Ressources now

@JensHeinrich
Copy link
Author

Ok

@martialblog
Copy link
Owner

@JensHeinrich no worries, every PR is welcome for discussion. I agree with @jacksgt though (trust me he's a Pro).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tweak entrypoints.sh
3 participants