Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional check for $ENCRYPT_SECRET_BOX_KEY to the entrypoint-security.php-creation #173

Closed
wuarmin opened this issue Oct 24, 2023 · 3 comments · Fixed by #174
Closed
Assignees
Labels
enhancement New feature or request

Comments

@wuarmin
Copy link
Contributor

wuarmin commented Oct 24, 2023

Hey,

I think the env variable $ENCRYPT_KEYPAIR is not used at newer versions. So we should add a check for the presence of $ENCRYPT_SECRET_BOX_KEY to decide if the security.php file should be created. WDYT?

if [ -n "$ENCRYPT_KEYPAIR" ]; then

if [ -n "$ENCRYPT_KEYPAIR" ] || [ -n "$ENCRYPT_SECRET_BOX_KEY" ]; then

best regards

@martialblog
Copy link
Owner

Hi,

you mean newer versions of LimeSurvey? Yes if the current LS version doesn't use this anymore, we can update the condition for the security.php.

Do you want to open a PR?

Thanks for noticing

@wuarmin
Copy link
Contributor Author

wuarmin commented Oct 24, 2023

Hello @martialblog,

you mean newer versions of LimeSurvey?

Yes I mean versions >=5. We use version 6 and have to provide a dummy $ENCRYPT_KEYPAIR to make the composing work.
I created a #174

best regards

@martialblog
Copy link
Owner

Merged and I just added the new LS tags, so the Images will be updated shortly.

Thannks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants