[Feature Request]: setting the clipboard as the default register

[angelacastaneda]

What feature would you like to see?

what's the best way of making the clipboard the default register in vis? where copying, pasting, and all the rest is no different than clipboard = "unnamedplus" in neovim?

this patch everyone got working for them is very outdated: #1003 (comment)

there was this lua code I found for setting it defacto (I couldn't get it working in my visrc):

vis:map(vis.modes.VISUAL, ' y', '"+y')
vis:map(vis.modes.VISUAL, ' p', '"+p')

but it seems less complete than manually patching in the default register.

someone made a quick patch for me:

diff --git a/vis-registers.c b/vis-registers.c
index 6e21a58..490ee77 100644
--- a/vis-registers.c
+++ b/vis-registers.c
@@ -152,7 +152,9 @@ bool register_slot_put_range(Vis *vis, Register *reg, size_t slot, Text *txt, Fi
 		if (len == SIZE_MAX || !buffer_reserve(buf, len+1))
 			return false;
 		buf->len = text_bytes_get(txt, range->start, len, buf->data);
-		return buffer_append(buf, "\0", 1);
+		if (!buffer_append(buf, "\0", 1))
+			return false;
+		/* fallthrough */
 	}
 	case REGISTER_CLIPBOARD:
 	{

it gets yank working but not paste, and I'm not confident enough in my C to know how sturdy this will actually hold up.

Please share lua and/or C patches below. I am grateful to all that help me detach myself from neovim.

[urosmikanovic]

This works ok for me.

		vis:map(m.NORMAL,      'y', '<vis-register>+<vis-operator-yank>')
		vis:map(m.VISUAL,      'y', '<vis-register>+<vis-operator-yank>')
		vis:map(m.VISUAL_LINE, 'y', '<vis-register>+<vis-operator-yank>')
		vis:map(m.NORMAL,      'd', '<vis-register>+<vis-operator-delete>')
		vis:map(m.VISUAL,      'd', '<vis-register>+<vis-operator-delete>')
		vis:map(m.VISUAL_LINE, 'd', '<vis-register>+<vis-operator-delete>')
		vis:map(m.NORMAL,      'p', '<vis-register>+<vis-put-after>')
		vis:map(m.VISUAL,      'p', '<vis-register>+<vis-put-after>')
		vis:map(m.VISUAL_LINE, 'p', '<vis-register>+<vis-put-after>')
		vis:map(m.NORMAL,      'P', '<vis-register>+<vis-put-before>')
		vis:map(m.VISUAL,      'P', '<vis-register>+<vis-put-before>')
		vis:map(m.VISUAL_LINE, 'P', '<vis-register>+<vis-put-before>')

[angelacastaneda]

@urosmikanovic thanks. seems pretty thorough, but you've got duplicates with VISUAL_LINE delete and NORMAL yank.

[mcepl]

Many times duplicate bug, see e.g. #1003

[angelacastaneda]

I mentioned a patch from that issue above. it is outdated however, so I wanted to open a new issue.