Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upload release zip to assets #19

Open
SuperSandro2000 opened this issue Mar 16, 2022 · 8 comments
Open

Upload release zip to assets #19

SuperSandro2000 opened this issue Mar 16, 2022 · 8 comments

Comments

@SuperSandro2000
Copy link

When packaging fonts for a package manager it is very inconvenient if the tip is uploaded in the markdown, not the assets because the resulting URL does not contain the git tag and can't be easily updated.

https://github.com/marnen/borg-sans-mono/files/107663/BorgSansMono.ttf.zip could be https://github.com/marnen/borg-sans-mono/releases/download/v0.2.0/BorgSansMono.ttf.zip

@AtilaSaraiva
Copy link

I second this!

@marnen
Copy link
Owner

marnen commented Mar 16, 2022

@SuperSandro2000 I don’t understand the issue here or what you’d like me to do about it. Can you be a little clearer?

@SuperSandro2000
Copy link
Author

The current download URL of the font is https://github.com/marnen/borg-sans-mono/files/107663/BorgSansMono.ttf.zip which can't be easily updated.
If it would be uploaded to assets like it is done here https://github.com/cli/cli/releases it could be easily updated in package managers.

@marnen
Copy link
Owner

marnen commented Mar 16, 2022

What makes it hard to update this way? How would putting the file under assets help? (I hardly ever use package managers for fonts, so I don’t understand the problem here.)

I’m not sure how to add files to assets on a release, so if you know, I’d be happy for your help on this.

@SuperSandro2000
Copy link
Author

What makes it hard to update this way?

The URL has a random number after files which would need a custom update script to get. When uploaded to assets only the last tag name is used which is already automated.

How would putting the file under assets help?

You can edit the release and add a file to assets. https://docs.github.com/en/repositories/releasing-projects-on-github/managing-releases-in-a-repository#:~:text=Optionally%2C%20to%20include%20binary%20files%20such%20as%20compiled%20programs%20in%20your%20release%2C%20drag%20and%20drop%20or%20manually%20select%20files%20in%20the%20binaries%20box.

@marnen
Copy link
Owner

marnen commented Mar 16, 2022

I believe those instructions are what got me to put the files where they are today.

I’ll look again, though.

@SuperSandro2000
Copy link
Author

Then you moved the files into the wrong box. The box to upload assets is below the text box.

@marnen
Copy link
Owner

marnen commented Mar 16, 2022

There were not two places to put files the last time I made a release. Perhaps this has changed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants