Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

notebook rendering does not work in jupyterlab #183

Open
bmcfee opened this issue Feb 21, 2018 · 3 comments
Open

notebook rendering does not work in jupyterlab #183

bmcfee opened this issue Feb 21, 2018 · 3 comments
Labels
bug interoperability Making JAMS play nice with other packages
Milestone

Comments

@bmcfee
Copy link
Contributor

bmcfee commented Feb 21, 2018

Probably something changed dramatically in the CSS between jupyter notebook and jupyterlab.

Anyone interested in taking a look at this?

@bmcfee bmcfee added this to the 0.3.2 milestone Apr 13, 2018
@bmcfee
Copy link
Contributor Author

bmcfee commented May 5, 2018

Looked into this: the problem is that jupyterlab no longer uses bootstrap, so the CSS classes we used for rendering JAMS objects in juypter notebook are now missing; specifically panels and panel-groups.

This is related to these threads: jupyterlab/jupyterlab#3200 jupyterlab/jupyterlab#2693 . It sounds like the jupyter folks want to expose some common CSS classes for this sort of thing, but it's unclear whether that would include enough functionality to get the nesting/expansion behavior we use currently.

@bmcfee bmcfee removed this from the 0.3.2 milestone Jun 1, 2018
@bmcfee
Copy link
Contributor Author

bmcfee commented Jun 1, 2018

I think we should hold off on fixing this. Jupyterlab seems to be a bit in flux about supporting styled outputs, so any fix we do in the short term would need to be revisited down the road anyway.

Going forward, I think a better long-term solution would be the following:

The above is generally blocked by jams 0.4 (at least) and jupyterlab 1.0, so we can punt it for now.

@bmcfee bmcfee added interoperability Making JAMS play nice with other packages and removed enhancement labels Aug 12, 2019
@bmcfee bmcfee added this to the 0.4.0 milestone Aug 12, 2019
@bmcfee
Copy link
Contributor Author

bmcfee commented Dec 1, 2019

For a quicker solution, we could do like xarray and just bundle our own CSS. This is probably the easiest and most reliable path forward.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug interoperability Making JAMS play nice with other packages
Projects
None yet
Development

No branches or pull requests

1 participant