Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Security concern on calling /usr/local/bin/clustercheck #96

Open
fbrehm opened this issue Sep 4, 2017 · 4 comments
Open

Security concern on calling /usr/local/bin/clustercheck #96

fbrehm opened this issue Sep 4, 2017 · 4 comments

Comments

@fbrehm
Copy link

fbrehm commented Sep 4, 2017

In the way, how /usr/local/bin/clustercheck is called by xinetd, the password of the MySQL user is visible in the command line (via 'ps -ef') during the execution of this script. But passwords should never be visible on the command line.

A better way for my opinion should be to generate a special 'my.somehow.cnf' somewhere in the filesystem, include the MySQL host, user and password as key-value-pairs inside the [client]-division of this file, restrict the access to this file, so that only the clustercheck-user is able to read this file and call mysql in the clustercheck-script with this file as a '--defaults-extra-file' parameter without giving host, user and password separately.

@fraenki fraenki self-assigned this Dec 10, 2017
@fraenki fraenki added bug and removed feature labels Feb 27, 2018
@fraenki
Copy link
Member

fraenki commented Feb 27, 2018

I agree. We should use login paths here, I have to check if this is supported on all platforms.

@fraenki
Copy link
Member

fraenki commented Aug 10, 2018

I'd really like to implement this using MySQL's login paths, but puppetlabs-mysql currently does not support them: https://tickets.puppetlabs.com/browse/MODULES-1550
Everyone who is concerned about security should vote for this feature. :)

@fraenki fraenki added upstream and removed bug labels Aug 21, 2018
@fraenki fraenki added this to the 2.0.0 milestone Feb 9, 2020
@fraenki fraenki modified the milestones: 2.0.0, 3.0.0 Mar 1, 2020
@fraenki
Copy link
Member

fraenki commented Apr 6, 2020

It looks like puppetlabs-mysql will receive support for login paths soon:
puppetlabs/puppetlabs-mysql#1295
This would allow us to improve security on MySQL-based systems.

@fraenki fraenki added feature and removed upstream labels Jun 17, 2020
@fraenki fraenki removed this from the 3.0.0 milestone Oct 31, 2022
@ajdelgado
Copy link

The feature has been added (and now I finished my PR regarding the cklustercheck that might have blocked this), so it would be good to have this feature

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants