Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plot.xbal fails if report = 'chisq' #81

Open
josherrickson opened this issue Dec 5, 2016 · 0 comments
Open

plot.xbal fails if report = 'chisq' #81

josherrickson opened this issue Dec 5, 2016 · 0 comments

Comments

@josherrickson
Copy link
Collaborator

This may be intended behavor, but if so, the terminology seems odds to me.

> plot(xBalance(pr ~ cost, data = nuclearplants))
> plot(xBalance(pr ~ cost, data = nuclearplants, report = 'all'))
> plot(xBalance(pr ~ cost, data = nuclearplants, report = 'chisq'))
Error in adrop.default(x$results, drop = 2) :
  dimensions to drop (2) do not have length 1

Seems that report really means compute. I had previously thought report to only be an argument passed to print.xbal, and that all three xbal objects were identical except their call.

Suggestions are either to deprecate report = for something like calculate or save, or making it behave like an actual report option.

(This came up for some slides I'm creating, I want to see xBalance output and plot, but the full output is too cluttered. However, I'm trying to avoid confusing users, so would prefer to avoid either running two xBalance calls or using print.xbal explicitly.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant