Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixup IntelliSense-related behavior #368

Merged
merged 39 commits into from
Jul 29, 2023
Merged

Fixup IntelliSense-related behavior #368

merged 39 commits into from
Jul 29, 2023

Conversation

mark-wiemer
Copy link
Member

@mark-wiemer mark-wiemer commented Jun 21, 2023

Closes #110.

Hoping to address #250

Breaking changes:

  • Rename some settings. Users will have to manually adjust these new settings from the defaults to match their old settings:
    • ahk++.formatter.indentCodeAfterSharpDirective is now ahk++.formatter.indentCodeAfterIfDirective
    • ahk++.language.enableIntellisense is now ahk++.intellisense.enableIntellisense
    • ahk++.file.maximumParseLength is now ahk++.intellisense.maximumParseLength

Other changes:

  • IntelliSense no longer suggests words when a user presses space (Issue #110)
  • IntelliSense now suggests foo(p1, p2) instead of foo (p1,p2)
  • Improved descriptions of settings

Engineering changes:

  • prefer-const
  • Add manual tests to repo (previously were untracked)
  • Update v1 and v2 demos
  • Method class now refers to uriString: string, not document: vscode.TextDocument
  • Rewrite CompletionProvider.provideCompletionItems and add unit tests

@mark-wiemer mark-wiemer marked this pull request as ready for review July 29, 2023 15:02
@mark-wiemer mark-wiemer added this pull request to the merge queue Jul 29, 2023
Merged via the queue into main with commit 761d758 Jul 29, 2023
@mark-wiemer mark-wiemer deleted the remove-intellisense branch July 29, 2023 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Space key suggestion bug
1 participant