Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support passing branches, commits, etc #36

Closed
marinofelipe opened this issue Apr 13, 2022 · 2 comments
Closed

Support passing branches, commits, etc #36

marinofelipe opened this issue Apr 13, 2022 · 2 comments
Assignees
Labels
enhancement New feature or request feature-request good first issue Good for newcomers

Comments

@marinofelipe
Copy link
Owner

marinofelipe commented Apr 13, 2022

Currently the tool only support tags, and defaults to the latest tag, which doesn't work for all scenarios, e.g. when the latest tag doesn't contain a valid Package.swift in the repository root, as reported by @ipedro.

A concrete example is https://github.com/dzenbot/DZNEmptyDataSet.

The goal with this issue is to evaluate and add support for a more flexible approach, in which not only tags can be passed, but also branches, revision items, and where the behavior of the tool is a bit more predictable.

Some top of mind ideas for that would be to either:

  • Additional Optional argument(s), like branch and revision
  • Or update -v to be a wild card argument, that can be named either v, branch or revision, that allows passing any of those and smartly resolves it
@marinofelipe marinofelipe added enhancement New feature or request good first issue Good for newcomers feature-request labels Apr 13, 2022
@marinofelipe marinofelipe moved this to Todo in Open tasks Apr 13, 2022
@marinofelipe marinofelipe self-assigned this Jan 15, 2023
@marinofelipe marinofelipe moved this from Todo to In Progress in Open tasks Jan 15, 2023
@marinofelipe marinofelipe moved this from In Progress to Todo in Open tasks Jan 2, 2024
@marinofelipe marinofelipe removed their assignment Jan 2, 2024
@marinofelipe
Copy link
Owner Author

After #44 this got simpler, the SwiftPM lib has built in support for checking out a revision

@marinofelipe marinofelipe moved this from Todo to In Progress in Open tasks Jan 28, 2024
@marinofelipe marinofelipe self-assigned this Feb 3, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Done in Open tasks May 26, 2024
@marinofelipe
Copy link
Owner Author

Shipped with the 1.5.0 release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request feature-request good first issue Good for newcomers
Projects
Status: Done
Development

No branches or pull requests

1 participant