Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block voting button if are on the last block of a period or on the first block #7

Open
zamrokk opened this issue Mar 14, 2022 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@zamrokk
Copy link
Collaborator

zamrokk commented Mar 14, 2022

SUMMARY: Block voting button if are on the last block of a period or on the first block

IMPACT:

  • last block : vote will not be taken into account because when the block will be forged, it will appear on the next period and so, be rejected by the smart contract
  • first block : first block needs to be forged on tezos for the next period index to be display on the chain, then update of the oracle will appear on the second block (normally...if no delay), then when voting :
    • vote tx is also on 1st block => rejection
    • vote tx is also on oracle update or before => rejection
      Solution ? compare oracle index and tezos index, if different, not time to vote, if sync, then all is fine for voting. So VOTE button can be displayed

REPRODUCTION:

  • last block : vote on last block of voting period
  • first block :
    • vote on first block
    • vote before oracle is updated
@zamrokk zamrokk assigned zamrokk and AngryStitch and unassigned zamrokk and AngryStitch Mar 14, 2022
@zamrokk zamrokk added the enhancement New feature or request label Mar 22, 2022
@zamrokk
Copy link
Collaborator Author

zamrokk commented Sep 7, 2023

minor bug, low priority

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants