Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TOTK] Armor dye dropdown appearing enabled when it shouldn't #421

Open
phil-macrocheira opened this issue Dec 21, 2023 · 2 comments
Open
Labels

Comments

@phil-macrocheira
Copy link
Contributor

  • Some armors are dyeable that shouldn't be, such as Evil Spirit Mask, Ravio's Hood, Majora's Mask, etc
  • Korok Seed quantity is capped at 999, but should be capped at 1000
marcrobledo added a commit that referenced this issue Jan 2, 2024
@marcrobledo
Copy link
Owner

Indeed, those armors should appear as not dyeable:
imagen

However, some months ago there was a little update (commit 6f4674d) that changed this.
A mod creator reported that their mod allowed those armors to be dyed in-game. Since the editor is based in the original unmodded game, those armor dye dropdowns appeared as disabled. So when they opened the savegame in the editor and saved, it reseted their dye values.
I did this small fix which only applies to mods: if you open a savegame that includes any of those armors with a dye, the dropdown does not appear disabled, so it keeps its value when saved.
Probably, you are opening a modded savegame with that armor dyed. But if you set it to its default value, save and reopen it, the dropdown should appear again disabled. Let me know if it works.

As of Korok seeds, fixed! Thank you as always, Phil :-)

@phil-macrocheira
Copy link
Contributor Author

Changing an armor in a slot (or even just clicking to change it and then clicking away) re-activates the dye dropdown. When an invalid color is selected, it re-disables the dye dropdown and displays an invalid icon for the armor. If saved, armor behaves normally but their icons do not render. Users must re-select the armor and change to 'Default color' before saving in the editor to fix it.

@marcrobledo marcrobledo changed the title [TOTK] Bug Report [TOTK] Armor dye dropdown appearing enabled when it shouldn't Jan 2, 2024
@marcrobledo marcrobledo added the bug label Jan 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants