Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No actually an issue : ported to package:html5 #21

Open
dam0vm3nt opened this issue Sep 7, 2017 · 3 comments
Open

No actually an issue : ported to package:html5 #21

dam0vm3nt opened this issue Sep 7, 2017 · 3 comments

Comments

@dam0vm3nt
Copy link

Hi,
I've ported your great lib to package:html5 and published to pub.

Just to let you know.

@marcojakob
Copy link
Owner

marcojakob commented Sep 7, 2017

Hi @dam0vm3nt. Great! Awesome that you can use it and made a port.

I couldn't find the source code - you're still linking to the original dnd source code in pub. I think it would make sense to link to your version in pub and just leave a link the original source as attribution in the README.

The other option would be to merge your code into the original version. Is it a big change? Is it something different or just an improvement?

@dam0vm3nt
Copy link
Author

Ouch! You're right. The code is here, but I'll add it to the readme and pubspec as well.

package:html5 is my experimental alternative html layer that works only on dartdevc and it leverages js-interop. It is slight different from dart:html but there's a chance that dnd can be refactored in a way that makes it work with both. Onestly I was interested only to check if dnd could work with package:html5 (and it works great!), so I did a very rough translation between the two api.

It's working for me but not sure 100% of everything I've changed. If you want you can give it a look.

Anyway thanks for you great work!

@marcojakob
Copy link
Owner

Nice. Keep us posted how the experiment continues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants