Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

min-, max- attributes are not HTML standard compliant #294

Open
fabasoft-michael-stedry opened this issue May 11, 2020 · 3 comments
Open

Comments

@fabasoft-michael-stedry

This library forces the user to use non-standard HTML attributes (eg. min-width, min-height, max-width, max-height) which prevents the resulting software to receive HTML compliance certification.

To alleviate this problem I have created the PR #273 and it works without a hitch for the 1 year we have it in production.

Could you please review and merge it if there is no problem with it? It would be nice to be able to use the official version instead of our fork.

@marcj
Copy link
Owner

marcj commented Jul 3, 2020

prevents the resulting software to receive HTML compliance certification

Who are you trying to impress with that? I prefer UX over unnecessary pedantic compliance. Custom non-data- attributes will always work in browser engines without complains, so you shouldn't worry about that.

@fabasoft-michael-stedry
Copy link
Author

Hi Marc, who we are trying to "impress" are the certification auditors, since we want/need our product to be certified.
See https://www.fabasoft.com/en/about-us/transparency/certifications-and-audits

Do you have a personal problem with your library being compliant when someone else adds such feature in a backward compatible way?

@awacode21
Copy link

I would appreciate this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants