You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Ok, I see that this issue lacked explaining. There were two questions:
we worry about the possibility that a contest has endTime but no startTime? Doesn't make any sense to me, but should we maybe log it?
This scenario is ignored by both pull requests for the csacademy branch: #14 and #22. There was also another question that was:
A contest might be upcoming or running if it has a startTime but no endTime. Shouldn't some of this conditions be outside of the if on line 33 because of this? Or should contest.state be undefined on those scenarios?
This is adressed by #22. If a contest has no endTime it never leaves the RUNNING state. We should discuss if this is a good idea.
Resolve the discussions proposed on this review.
The text was updated successfully, but these errors were encountered: