Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Questions about optional fields on fetchers #20

Open
victorsenam opened this issue May 7, 2018 · 2 comments
Open

Questions about optional fields on fetchers #20

victorsenam opened this issue May 7, 2018 · 2 comments
Labels
minor question Further information is requested

Comments

@victorsenam
Copy link
Member

Resolve the discussions proposed on this review.

@victorsenam victorsenam added question Further information is requested minor labels May 7, 2018
@pedroteosousa
Copy link
Member

I don't understand what you mean by optional fields on fetchers, I read the review and found no reference to this.

@victorsenam
Copy link
Member Author

Ok, I see that this issue lacked explaining. There were two questions:

we worry about the possibility that a contest has endTime but no startTime? Doesn't make any sense to me, but should we maybe log it?

This scenario is ignored by both pull requests for the csacademy branch: #14 and #22. There was also another question that was:

A contest might be upcoming or running if it has a startTime but no endTime. Shouldn't some of this conditions be outside of the if on line 33 because of this? Or should contest.state be undefined on those scenarios?

This is adressed by #22. If a contest has no endTime it never leaves the RUNNING state. We should discuss if this is a good idea.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
minor question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants