Unproject screen coordinates on terrrain - missing implementation?

[dennemark]

Hi,
does map.unproject properly consider terrain?
I followed the code leading to the pointLocation function in transform (

maplibre-gl-js/src/geo/transform.ts

Line 581 in c01e231

return this.coordinateLocation(this.pointCoordinate(p, terrain));

), it then calls coordinateLocation and applies terrain as argument, but actually coordinateLocation does not have a terrain arg. Am I missing something?
I feeld like clicking on the map and calling map.unproject, I get the lngLat on a plane, but not on the terrain.

Someone knows more about it? Is there another function? I could investigate it otherwise.
Best

[HarelM]

Can you write a more elaborate example? Maybe even a failing test?

[dennemark]

should i contribute the failing test as PR?

[HarelM]

Only if you plan to follow up, otherwise I'm afraid no one will pick it up...

[dennemark]

Ok after investigating it a bit loser I realised I had to look at pointCoordinate and not at coordinateLocation. So terrain is actually called. I am going to assume that the calculation is correct even though not tested.