Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use box2d<value_type> in decode_geometry #206

Open
springmeyer opened this issue Apr 19, 2016 · 0 comments
Open

Use box2d<value_type> in decode_geometry #206

springmeyer opened this issue Apr 19, 2016 · 0 comments

Comments

@springmeyer
Copy link
Contributor

The bbox used in decode_geometry is currently hardcoded to double. It should be using the value_type for best performance:

template <typename value_type>
MAPNIK_VECTOR_INLINE mapnik::geometry::geometry<value_type> decode_geometry(GeometryPBF & paths,
int32_t geom_type,
unsigned version,
value_type tile_x,
value_type tile_y,
double scale_x,
double scale_y,
mapnik::box2d<double> const& bbox)
{

Waiting on mapnik/mapnik#3405

@springmeyer springmeyer changed the title Use box2d<value_type in decode_geometry Use box2d<value_type> in decode_geometry Apr 19, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant